Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed first 2 chars of authority from IDENTIFIER blocking key #227

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Feb 27, 2025

Description

Changing IDENTIFIER blocking keys to {value[-4:]}:{type} format, authority is no longer present in the keys.

BREAKING CHANGE: The format of IDENTIFIER blocking keys has changed, and databases should be reset before upgrading.

Related Issues

closes #226

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

BREAKING CHANGE: The format of IDENTIFIER blocking keys has changed, and
databases should be reset before upgrading.
@ericbuckley ericbuckley self-assigned this Feb 27, 2025
@ericbuckley ericbuckley added the feature New feature or request label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (d54af84) to head (7812e69).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   97.69%   97.70%           
=======================================
  Files          32       32           
  Lines        1651     1653    +2     
=======================================
+ Hits         1613     1615    +2     
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review February 27, 2025 02:12
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy, a good fix

@ericbuckley ericbuckley merged commit 1027b73 into main Feb 28, 2025
16 checks passed
@ericbuckley ericbuckley deleted the feature/226-identifier-blocking-remove-auth branch February 28, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make IDENTIFIER blocking key less restrictive
2 participants