-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new schema mpi fuctions #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! This makes the code much more readable, and I appreciate the attention to detail in testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your detailed responses 🙌🏼 Appreciate your thoughts on the ways we can optimize the algorithm!
…key value is missing
Description
Implementing the MPI functions,
get_block_data
andinsert_matched_patient
, using the new schema.Related Issues
closes #10
Additional Notes
settings.db_uri
now has the information that we used dotenv to load, so we don't need this anymoreChecklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: