-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New scenario types and associated make_Rt
methods
#327
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 50 50
Lines 528 528
=======================================
Hits 492 492
Misses 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd missed you were PR stacking so review comments on the other PR are mostly for here I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me.
PR contextFrom f2f conversation @seabbs is a bit uncomfortable that we essentially have two patterns here:
My argument is that because there are a small(ish) number of "truth data" scenarios we are considering, this is clearer/easier at the moment but we should consider a trait-based system to ship with an NB: the truth data scenarios still contain a list of |
This PR does two things:
make_Rt
methods which determine theRt
time series set by the scenario along with docstring examples of how to plot the decision for visual inspection.As well as extension of unit tests to cover the new structs and functions.
NB: I've taken the definition of "endemic" to mean a geometric mean of$R_t$ over the time period is unity,
This approximately ensures a time average stationarity in cases, i.e. stable endemicity.
Closes #325 and #326 .