-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eCR Viewer setup script + variable pattern setting 🖌️ #51
Open
alismx
wants to merge
16
commits into
main
Choose a base branch
from
alis/21_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+408
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…docker-compose This commit updates the environment variables configurations across different services and updates the services docker images to v2.0.0-beta in the docker-compose.yml file. Also, includes user guides for VM launch in AWS and Proxmox environments.
…er structure, add VM build script
I converted back to draft because the environment variables did not stay set in the ways I expected. I'll reopen this for review shortly. |
Refactor the handling of environment variables in dibbs-ecr-viewer docker configuration. Migrate environment variables from hard-coded settings in ecr-viewer.env file to dynamic generation using a wizard script. Add backup for old environment settings. Update gitignore to include new .env files and backups.
…uild process scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed
dibbs_service
anddibbs_version
to enable selecting a dibbs project during builds..gitignore
~/.bashrc
file which sets vars across rebootspackMachines.yml
, to create Docker images dynamically based on provided service and version inputs.docker-compose.yml
to remove hardcoded image versions and allow the version to be set as an environment variable at build time.build.sh
script is also included inutils/
for executing the Packer build with the required service and version variables.Additional Information
Testing
Reviewers can verify these changes by:
./build.sh dibbs-ecr-viewer v2.0.0-beta
sudo ./wizard.sh