Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse by Poet names missing punctuation #399

Closed
erinchambers opened this issue Nov 21, 2024 · 6 comments · Fixed by #393 · May be fixed by CDRH/api#146
Closed

Browse by Poet names missing punctuation #399

erinchambers opened this issue Nov 21, 2024 · 6 comments · Fixed by #393 · May be fixed by CDRH/api#146
Assignees
Labels
bug Something isn't working close? review then close

Comments

@erinchambers
Copy link
Contributor

erinchambers commented Nov 21, 2024

Names on these browse pages are missing the comma between last name and first time (e.g. “Abdullah Fathi” should be “Abdullah, Fathi”), as well as other punctuation (e.g. the apostrophes in ‘Achebe, Chinua ‘Albert Chinualumogu’)

Related to #400

Note: the names on the Browse News by African Poet have all the correct punctuation https://cdrhrailsdev.unl.edu/african-poetics/inthenews/news/browse/contributor.name

@erinchambers erinchambers added this to the Rails Migration milestone Nov 21, 2024
@erinchambers erinchambers changed the title Index of Poets browse - names are missing commas Missing comma in poet names (Last Name, First Name) Nov 21, 2024
@erinchambers erinchambers changed the title Missing comma in poet names (Last Name, First Name) Missing punctuation in poet names (Last Name, First Name) Nov 21, 2024
@erinchambers erinchambers changed the title Missing punctuation in poet names (Last Name, First Name) Browse by Poet names missing punctuation Nov 21, 2024
@wkdewey
Copy link
Contributor

wkdewey commented Nov 26, 2024

I think these are fixed with my recent API changes. It would be necessary to restart the server to see the changes.

This was linked to pull requests Nov 27, 2024
@wkdewey
Copy link
Contributor

wkdewey commented Nov 27, 2024

This is now working on the dev server

@erinchambers
Copy link
Contributor Author

Looks great. Thanks, Will—closing the issue.

@erinchambers
Copy link
Contributor Author

erinchambers commented Dec 11, 2024

@wkdewey this is happening again on In the News browse/search facets

Here are the places I've noted so far:

@karindalziel karindalziel reopened this Dec 12, 2024
@erinchambers erinchambers added the bug Something isn't working label Dec 12, 2024
@wkdewey
Copy link
Contributor

wkdewey commented Dec 12, 2024

I brought cdrhapi.unl.edu/v2 up to date on cors1601 and the issues went away. I will also do the same on cdrhrails.

@wkdewey
Copy link
Contributor

wkdewey commented Dec 12, 2024

looks like cdrhrails api is also up to date (for whatever version we are going to point there)

@wkdewey wkdewey added the close? review then close label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working close? review then close
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants