Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse by Country missing punctuation, sentence case capitalization #400

Closed
erinchambers opened this issue Nov 21, 2024 · 2 comments · Fixed by #393
Closed

Browse by Country missing punctuation, sentence case capitalization #400

erinchambers opened this issue Nov 21, 2024 · 2 comments · Fixed by #393
Assignees
@wkdewey
Labels
bug Something isn't working close? review then close
Milestone
Dev Push final cl...

Comments

@erinchambers
Copy link
Contributor

  • Punctuation is missing from country names on the Index of Poets “Browse by Country” page (e.g. “Trieste, Kingdom of Italy” or “ São Tomé e Príncipe”)
  • Words like ‘of’ and ‘the’ are capitalized in the Browse list, even though they’re lowercase in the data (e.g. “Democratic Republic Of The Congo”)

Related to #399
@erinchambers erinchambers added this to the Rails Migration milestone Nov 21, 2024
@erinchambers erinchambers mentioned this issue Nov 21, 2024
Closed
@wkdewey wkdewey linked a pull request Nov 27, 2024 that will close this issue
V2 upgrade #393
Merged
wkdewey added a commit that referenced this issue Nov 27, 2024
@wkdewey
modify browse page so facets display properly
e3408f6 
bring up to date with Orchid and API V2
fixes #400
@erinchambers
Copy link
Contributor Author

@wkdewey this is happening again on the live site: https://africanpoetics.unl.edu/inthenews/poets/browse/spatial.short_name

@erinchambers erinchambers reopened this Dec 11, 2024
@erinchambers erinchambers added bug Something isn't working and removed x_close? labels Dec 11, 2024
@wkdewey
Copy link
Contributor

wkdewey commented Dec 12, 2024

Fixed now that I pulled the API on cors1601

@wkdewey wkdewey added the close? review then close label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkdewey wkdewey

Labels
bug Something isn't working close? review then close
Projects
None yet
Milestone
Dev Push final cleanup
Development

Successfully merging a pull request may close this issue.

V2 upgrade CDRH/african_poetics
3 participants
@karindalziel @erinchambers @wkdewey