Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rspec #118

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Rspec #118

wants to merge 4 commits into from

Conversation

jduss4
Copy link
Contributor

@jduss4 jduss4 commented Oct 31, 2021

Switches from minitest to rspec for the test suite

You can take or leave this change, because I didn't consult anybody there before I decided just to do it!

A couple things to be aware of:

  • I started an adr folder in docs which stands for "architectural decision record." We are using these at my current job and I really like them as a way to keep track of why we did things and when.
  • I actually do think rspec will probably be better for testing out the API long-term, not that I was just changing things for kicks and giggles
  • I didn't refactor any code in the tests beyond a few changes of descriptions and that sort of thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karindalziel karindalziel Awaiting requested review from karindalziel

@techgique techgique Awaiting requested review from techgique

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
v3 future features
Development

Successfully merging this pull request may close these issues.
3 participants
@jduss4 @karindalziel @wkdewey