Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facet display #136

Closed
wants to merge 39 commits into from
Closed

Facet display #136

wants to merge 39 commits into from

Conversation

wkdewey
Copy link
Contributor

@wkdewey wkdewey commented Oct 31, 2022

Raise the limit so that more results can display at one time on the facet sidebar.

wkdewey and others added 27 commits May 19, 2022 13:04
@wkdewey
upgrade Puma
561aeeb
@wkdewey
add specific version of puma to avoid security warnings
deb704a
@wkdewey
update .ruby-version
065857a
@wkdewey
update to later version of puma
38b02b7
@wkdewey
another round of gem updates
e763bb1
@wkdewey
add facet for matching nested facet
2769319
@wkdewey
add filter for matching nested facet
3b33d4a
@wkdewey
change split character, add missing comma
fa5c245
@wkdewey
parse the array for matching nested fields
21310ef
@wkdewey
change how compound facet name is parsed
4656dc6
@wkdewey
use facet name as agg name
2b3af8e 
this is not the most semantically correct, but it doesn't break anything and orchid seems to expect it
@wkdewey
change query to filter
100ac90 
this is necessary to make this sort of query work
@wkdewey
fix nested filter aggregation so it doesn't cause 400 error
3dd6608
@wkdewey
check for deeper nesting of buckets
fafb3a6
@wkdewey
Change separator
2ade65b
@wkdewey
Fix parsing and query for filter matching
3c223e4
@wkdewey
rewrite filtered aggregation to be either nested or not
ef22307
@wkdewey
filtering on a single item can either be nested or not
16a490d
@wkdewey
update config for server
b038be0
@wkdewey
revise query to match both the facet and the filter
6eaa38b
@wkdewey
use reverse nested agg for correct item count
88a8f80
@wkdewey
used doc_count from reverse nested if it exists
dd4bacd
@wkdewey
change key for new elasticsearch version
bd739e0
@wkdewey
change order query to avoid deprecated '_term'
f0c3124
@wkdewey
gitignore master key
7441a96
@wkdewey
add basic auth to elasticsearch requests
255f9db
@wkdewey
raise number of results per facet
b8ab6b0
@wkdewey
Copy link
Contributor Author

wkdewey commented Oct 31, 2022

I decided not to set the limit here, but revised it to use facet_limit from the Orchid app. Related to CDRH/orchid#260

@wkdewey wkdewey changed the base branch from dev to release/v2.0.0 November 7, 2022 19:41
@wkdewey
Copy link
Contributor Author

wkdewey commented Nov 9, 2022

added upgrade to Ruby 3 and Rails 6.1.7

@wkdewey
Copy link
Contributor Author

wkdewey commented Nov 10, 2022

also added documentation, closes #133

@wkdewey wkdewey mentioned this pull request Nov 10, 2022
Open
@wkdewey wkdewey changed the base branch from release/v2.0.0 to dev November 21, 2022 21:31
@wkdewey wkdewey changed the base branch from dev to nested-aggregations November 21, 2022 21:36
@wkdewey wkdewey changed the base branch from nested-aggregations to dev November 30, 2022 17:32
@wkdewey
Copy link
Contributor Author

wkdewey commented Nov 30, 2022

Splitting this one up; the new commits not in nested_aggregations relate to upgrading to rails 6 and documentation.

@wkdewey wkdewey closed this Nov 30, 2022
@wkdewey wkdewey deleted the facet_display branch November 30, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karindalziel karindalziel Awaiting requested review from karindalziel

@techgique techgique Awaiting requested review from techgique

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wkdewey