Calendar colors & code #157
Conversation
Alternate single-day entries with blue colors Alternate multi-day entries with orange and red-orange Compress JSON output by using HEREDOC with squish I saw this in some Rails source code and noted for future use :-) Add some whitespace and alphabetize some things
Use constants for output file and Solr URL Use easier syntax for fields array Add preliminary Solr request to retrieve # of rows query matches, so not relying on hard-coded rows number Use shorter Solr query syntax Print output so there is some feedback in the terminal Catch case that Solr index has no entries or failed, exit, and inform user
Calendar element would empty temporarily while redrawing new year's data and the footer would jump up and back down quickly Set min-height on #calendar so the footer remains below the display area
| if SOLR_URL | ||
| $solr = RSolrCdrh::Query.new(SOLR_URL, fields) | ||
|
|
||
| # Retrieve # of rows first so not relying on hard-coded limit |
There was a problem hiding this comment.
Using "rows" => 0 crashes, thus using 1. Using smallest field list minimizes data transfer of the prelim query.
Importance of not using really high Solr rows value, which links to a JIRA issue whose comments inspired this approach: http://stackoverflow.com/questions/10039778/how-to-get-all-results-from-solr-query#comment67310298_10080733
There was a problem hiding this comment.
Do you know why rows => 0 was crashing? I wonder if it's one of the gem layers, it seems like that shouldn't bother solr itself at all.
| if SOLR_URL | ||
| $solr = RSolrCdrh::Query.new(SOLR_URL, fields) | ||
|
|
||
| # Retrieve # of rows first so not relying on hard-coded limit |
There was a problem hiding this comment.
Do you know why rows => 0 was crashing? I wonder if it's one of the gem layers, it seems like that shouldn't bother solr itself at all.
| y1, m1, d1 = date1.split("-") | ||
| y2, m2, d2 = date2.split("-") | ||
| # javascript sucks at dates, so help it out | ||
|
|
||
| # javascript uses zero-indexed months |
There was a problem hiding this comment.
;-)
It would be nicer if everything worked the same so one didn't have to remember this, or be reminded by a later bug / inaccuracy. I'm used to Perl and JS being zero-indexed so the chore has been normalized for me.
Closes #105