-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU - gen fallback to shared if error #1740
Conversation
@zatkins-dev can I get your thoughts on the overall approach? This should basically let people use |
Yeah, I like the approach. I definitely think that it's good for users to be able to use |
10cebd5
to
d3a5b9e
Compare
d3a5b9e
to
8d12f40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good, with a few minor things
Co-authored-by: Zach Atkins <[email protected]>
acff3cc
to
c9192ac
Compare
Ok, there's two main reasons why a
gen
operator might failtoo much shared memory needed to compile
too many resources needed to run kernel
This PR adds a mechanism to automatically detect these issues and fall back to a
shared
operator.