Troubleshooting spawned tasks functionality#318
Open
rakovskij-stanislav wants to merge 3 commits intoCERT-Polska:masterfrom
Open
Troubleshooting spawned tasks functionality#318rakovskij-stanislav wants to merge 3 commits intoCERT-Polska:masterfrom
rakovskij-stanislav wants to merge 3 commits intoCERT-Polska:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR introduces the functionality of crashing SPAWNED tasks that are not in a queue.
At some point of time, I experienced severe issues with redis, and it borned a condition where Consumer already pulled the task_id from a queue but had not an opportunity to update task status SPAWNED->STARTED. This situation creates the condition when zombie tasks appear - neither Consumers not Karton-System can deal with it.
This PR implements additional checks to crash such kind of tasks.