Issue 215 add no instances of this issue found message on tabs on free text fields dashboard #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added line of code that displayed 'no instances found' on panels where there was no data
working on the free text fields panel. Standardised the structure of the json containing the panel data across all panels so that if a panel has no instances, the json contains a field with the name of that panel and an empty array as it's value. Fixed the code that was retrieving the CountryCode field for the free text fields panel, as it was using an incorrect name for the DDI field containing that data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed code that displays 'no instances found' message which wasn't working on the free text fields panel. Standardised the structure of the json containing the panel data across all panels so that if a panel has no instances, the json contains a field with the name of that panel and an empty array as it's value.
Fixed the code that was retrieving the CountryCode field for the free text fields panel, as it was using an incorrect name for the DDI field containing that data, resulting in that panel always being empty.