Fix: Remove url from required schema for upgrading plugins#148
Open
Fix: Remove url from required schema for upgrading plugins#148
Conversation
This reverts commit 4c4459c. git push origin main#
Refactor (src/user/posts.js): reduce complexity in isReady()
refactor: wrapped if-elseif-else statement in a function in filterTids
Refactor (public/src/modules/accounts/delete.js): reducing parameters in executeAction
Refactor src/api/posts.js to simplify Complex binary expression in canSeeVotes()
Add unread feature
Refactor (src/topics/posts.js:336): Function with many parameters (count = 4): incrementFieldAndUpdateSortedSet
feat: add unresolved count on homepage and categories page frontend only
… not sending.' or '[activitypub/api] Not federating update of pid 1 to the fediverse due to privileges.' since Privilege check runs before federation-disabled check
Fix: Mitigate timeout when in CI
…ed by previous PR Removed redundant 'activitypubEnabled' key from configuration.
This reverts commit a445178.
improvements: i think you should/need to clean up your console.log statements. i vaguely remember them saying they would check for that. also, did you add new test cases? if you made ui changes, you should have new frontend tests + new tests for your routes and controllers edit: improvements were made + tests passed on github! otherwise, number of lines edited + commit messages are aptly descriptive. PR is a bit redundant, but helps to guide me through all the changes you made. Pull the branch into my local machine, and tested that lint and test both run, and ui changes are visible! you should also move your tasks around on our project board. not sure if you were waiting for this pr to merge before moving to complete.
Merging Joon's PR that added a new page to view further user engagement stats under admin dashboard settings, code has been tested and reviewed
Feat: Added Endorsed Filter
Docs: Added User Guide
feat: added user:0 to docker-compose-redis.yml
Feat: added VM Deploy.yml to github workflow to connect our repo to t…
…ailgun secrets on the server
…d and modified by this server account
Fix: Create env file for mailgun secrets on the linux server
Pull Request Test Coverage Report for Build 19182234893Details
💛 - Coveralls |
… not end up in main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
urlis not required. Upgrade can be performed just with theid. Therefore, this PR patches the error by removing "url" from the required properties.