Draft: Add implementation of stable-priceability for cardinal ballots #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiktorGrzankowski
changed the title
Member
|
Hey Wiktor, Are you planning future commits on the same topic? If so, I will wait for everything to have been pushed before merging. |
Contributor
Author
|
Hey Simon, |
WiktorGrzankowski
changed the title
Member
|
Can you then close the pull request and re open it (or create a new one) once you have everything? That will avoid unnecessary emails. |
Member
|
Also, note that I am not working on this anymore so I won't review code or anything, just click the merge button ^^ I assume you're working with Piotr, and I thus assume that once you submit a PR the code will have been validated already. |
Contributor
Author
|
Ok, closing the PR until final version is created. |
Contributor
Author
|
Closign the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend functionality of priceable function to work not only for ApprovalBallot, but also for CardinalBallot.
Provide additional tests for stable-priceability for election with cardinal utilities, including regression tests, where CardinalBallots have binary utilities, to show that they are equivalent to working with ApprovalBallots.
Add methods supports and utility to AbstractBallot with actual implementations for CardinalBallot and ApprovalBallot. Notions of supporting candidates or having a particular utility from a candidate does not exist for OrdinalBallot, possibly subject to further work.