Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable #215

Merged
merged 27 commits into from
Aug 23, 2024
Merged

Stable #215

merged 27 commits into from
Aug 23, 2024

Conversation

bukhosi-eugene-mpande
Copy link
Contributor

Pull Request

Description:

[Provide a concise summary of your changes and why they are necessary.]

Related Issues:

[Reference any related issues or documents.]

Type of Change:

  • Bug Fix
  • New Feature
  • Enhancement
  • Refactoring
  • Documentation Update

Testing Instructions:

[Provide clear and concise instructions on how to test your changes.]

Additional Notes:

[Any additional information that may be helpful for reviewers.]

Copy link
Contributor

@JoshuaTristanWereley JoshuaTristanWereley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Good to me

Copy link
Contributor

@Ashley-Kapaso Ashley-Kapaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely ready for main

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 57.84753% with 188 lines in your changes missing coverage. Please review.

Project coverage is 15.96%. Comparing base (9fd3c6f) to head (d3cb4f0).
Report is 37 commits behind head on main.

Files Patch % Lines
src/src/lib/server/utils/auth.ts 0.00% 67 Missing ⚠️
src/src/lib/server/utils/email.ts 0.00% 59 Missing ⚠️
.../lib/server/database/schemas/PasswordResetToken.ts 0.00% 19 Missing ⚠️
src/src/lib/components/lessons/lesson/Scene.svelte 0.00% 12 Missing ⚠️
src/src/routes/(app)/+layout.server.ts 0.00% 9 Missing ⚠️
...c/lib/components/lessons/lesson/Environment.svelte 0.00% 7 Missing ⚠️
src/src/lib/server/auth.ts 0.00% 4 Missing ⚠️
src/src/lib/server/database/schemas/User.ts 0.00% 4 Missing ⚠️
src/src/routes/(auth)/signup/+page.server.ts 94.59% 2 Missing ⚠️
...rc/src/lib/components/lessons/lesson/Layout.svelte 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #215       +/-   ##
===========================================
- Coverage   66.96%   15.96%   -51.00%     
===========================================
  Files          41      182      +141     
  Lines         451     8461     +8010     
  Branches       14      349      +335     
===========================================
+ Hits          302     1351     +1049     
- Misses        149     7110     +6961     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bukhosi-eugene-mpande bukhosi-eugene-mpande merged commit cae6b88 into main Aug 23, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants