Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable #269

Merged
merged 39 commits into from
Sep 30, 2024
Merged

Stable #269

merged 39 commits into from
Sep 30, 2024

Conversation

bukhosi-eugene-mpande
Copy link
Contributor

Pull Request

Description:

[Provide a concise summary of your changes and why they are necessary.]

Related Issues:

[Reference any related issues or documents.]

Type of Change:

  • Bug Fix
  • New Feature
  • Enhancement
  • Refactoring
  • Documentation Update

Additional Notes:

[Any additional information that may be helpful for reviewers.]

Copy link
Contributor

@ayandajuqu ayandajuqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 61.70213% with 54 lines in your changes missing coverage. Please review.

Project coverage is 33.17%. Comparing base (95cbfe0) to head (1485cd1).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
src/src/routes/(app)/admins/+page.server.ts 0.00% 12 Missing ⚠️
src/src/routes/(app)/lecturers/+page.server.ts 0.00% 12 Missing ⚠️
src/src/routes/(app)/students/+page.server.ts 0.00% 12 Missing ⚠️
...kspaces/[workspace]/quizzes/[quiz]/+page.server.ts 0.00% 9 Missing ⚠️
src/src/lib/server/UploadHandler.ts 88.57% 4 Missing ⚠️
src/src/lib/store/model.ts 0.00% 3 Missing ⚠️
[...workspace]/environments/simulation/+page.server.ts](https://app.codecov.io/gh/COS301-SE-2024/ClassConnect/pull/269?src=pr&el=tree&filepath=src%2Fsrc%2Froutes%2F%28app%29%2Fworkspaces%2F%5Bworkspace%5D%2Fenvironments%2Fsimulation%2F%2Bpage.server.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COS301-SE-2024#diff-c3JjL3NyYy9yb3V0ZXMvKGFwcCkvd29ya3NwYWNlcy9bd29ya3NwYWNlXS9lbnZpcm9ubWVudHMvc2ltdWxhdGlvbi8rcGFnZS5zZXJ2ZXIudHM=) 97.22% 1 Missing ⚠️
src/src/routes/+page.server.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #269       +/-   ##
===========================================
+ Coverage   19.96%   33.17%   +13.21%     
===========================================
  Files         231       65      -166     
  Lines       12368     4223     -8145     
  Branches      493      320      -173     
===========================================
- Hits         2469     1401     -1068     
+ Misses       9899     2822     -7077     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Lunga-Ntando-Ndlovu Lunga-Ntando-Ndlovu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem quite decent

@bukhosi-eugene-mpande bukhosi-eugene-mpande merged commit c884bf5 into main Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants