Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deployment workflow: Set Nodejs Stage Variable #904

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Refactor deployment workflow: Set Nodejs Stage Variable #904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 26 additions & 36 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,26 @@ jobs:
run: |
npm ci

- name: Set Nodejs Stage Variable
working-directory: nodejs_api
run: |
if [ ${{ github.base_ref }} == 'main' ]; then
echo "STAGE=prod" >> $GITHUB_ENV
echo "TARGET_DEPLOYMENT_BUCKET=${{ secrets.NODEJS_DEPLOYMENT_BUCKET_PROD }}" >> $GITHUB_ENV
echo "TARGET_LAMBDA_ROLE=${{ secrets.NODEJS_LAMBDA_ROLE_PROD }}" >> $GITHUB_ENV
echo "TARGET_FUNCTION_NAME=mycity-nodejs-api-prod" >> $GITHUB_ENV
echo "TARGET_API_GATEWAY_NAME=mycity-nodejs-api-prod" >> $GITHUB_ENV
elif [ ${{ github.base_ref }} == 'development' ]; then
echo "STAGE=dev" >> $GITHUB_ENV
echo "TARGET_DEPLOYMENT_BUCKET=${{ secrets.NODEJS_DEPLOYMENT_BUCKET_DEV }}" >> $GITHUB_ENV
echo "TARGET_LAMBDA_ROLE=${{ secrets.NODEJS_LAMBDA_ROLE_DEV }}" >> $GITHUB_ENV
echo "TARGET_FUNCTION_NAME=mycity-nodejs-api-dev" >> $GITHUB_ENV
echo "TARGET_API_GATEWAY_NAME=mycity-nodejs-api-dev" >> $GITHUB_ENV
else
echo "No deployment for this branch"
exit 0
fi

- name: Generate serverless.yml
working-directory: nodejs_api
run: |
Expand All @@ -126,14 +146,13 @@ jobs:
- ${{ secrets.VPC_SECURITY_GROUP_ID }}
subnetIds:
- ${{ secrets.VPC_SUBNET_ID }}
stage: ${opt:stage, 'dev'} # default to 'dev' if no stage is specified
region: ${{ secrets.AWS_REGION }}
deploymentBucket:
name: ${self:custom.deploymentBuckets.${self:provider.stage}}
name: ${{ env.TARGET_DEPLOYMENT_BUCKET }}
iam:
role: ${self:custom.lambdaFunctionRoleARNS.${self:provider.stage}}
role: ${{ env.TARGET_LAMBDA_ROLE }}
environment:
API_ENV: ${self:provider.stage}
API_ENV: ${{ env.STAGE }}
USER_POOL_ARN: ${{ secrets.USER_POOL_ARN }}
USER_POOL_ID: ${{ secrets.USER_POOL_ID }}
S3_BUCKET_NAME: ${{ secrets.S3_BUCKET_NAME }}
Expand All @@ -142,7 +161,7 @@ jobs:
WEB_SOCKET_URL: ${{ secrets.WEB_SOCKET_URL }}
functions:
app:
name: ${self:custom.lambdaFunctionNames.${self:provider.stage}}
name: ${{ env.TARGET_FUNCTION_NAME }}
handler: dist/app.handler
events:

Expand Down Expand Up @@ -572,29 +591,12 @@ jobs:
authorizerId:
Ref: ApiGatewayAuthorizer

custom:
lambdaFunctionRoleARNS:
dev: ${{ secrets.NODEJS_LAMBDA_ROLE_DEV }}
prod: ${{ secrets.NODEJS_LAMBDA_ROLE_PROD }}

lambdaFunctionNames:
dev: mycity-nodejs-api-dev
prod: mycity-nodejs-api-prod

deploymentBuckets:
dev: ${{ secrets.NODEJS_DEPLOYMENT_BUCKET_DEV }}
prod: ${{ secrets.NODEJS_DEPLOYMENT_BUCKET_PROD }}

apiGatewayNames:
dev: mycity-nodejs-api-dev
prod: mycity-nodejs-api-prod

resources:
Resources:
ApiGatewayRestApi:
Type: AWS::ApiGateway::RestApi
Properties:
Name: ${self:custom.apiGatewayNames.${self:provider.stage}}
Name: ${{ env.TARGET_API_GATEWAY_NAME }}

ApiGatewayAuthorizer:
Type: AWS::ApiGateway::Authorizer
Expand All @@ -605,7 +607,7 @@ jobs:
Ref: ApiGatewayRestApi
IdentitySource: method.request.header.Authorization
ProviderARNs:
- ${self:provider.environment.USER_POOL_ARN}
- ${{ secrets.USER_POOL_ARN }}
EOF

- name: Set Up AWS CLI
Expand All @@ -616,18 +618,6 @@ jobs:
aws configure set aws_secret_access_key ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws configure set default.region ${{ secrets.AWS_REGION }}

- name: Set Nodejs Stage Name
working-directory: nodejs_api
run: |
if [ ${{ github.base_ref }} == 'main' ]; then
echo "STAGE=prod" >> $GITHUB_ENV
elif [ ${{ github.base_ref }} == 'development' ]; then
echo "STAGE=dev" >> $GITHUB_ENV
else
echo "No deployment for this branch"
exit 0
fi

- name: Deploy Serverless Express App
working-directory: nodejs_api
env:
Expand Down