Skip to content

Refactor expts manager tool iss42 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 31 commits into from

Conversation

minghangli-uni
Copy link
Contributor

Refactor the Experiment Manager tool into modular scripts for better readability and maintainence. See #42

@minghangli-uni minghangli-uni force-pushed the refactor_Expts_manager_iss42 branch from 6784819 to 114074e Compare January 17, 2025 09:01
@minghangli-uni minghangli-uni force-pushed the refactor_Expts_manager_iss42 branch from 114074e to 180d4ae Compare January 17, 2025 09:04
@minghangli-uni minghangli-uni marked this pull request as ready for review January 27, 2025 22:30
@minghangli-uni
Copy link
Contributor Author

Hi @dougiesquire , could you please review this PR when you are available?

@minghangli-uni
Copy link
Contributor Author

minghangli-uni commented Feb 10, 2025

Hello @aidanheerdegen @jo-basevi, this perturbation tool has been around for a while and we’re aware that payu offers similar functionalities for perturbation experiments with a helpful tutorial available on the forum.

@chrisb13, @dougiesquire, and I today had a discussion, and we agreed it would be valuable to have your review of this perturbation tool. We’re not looking for an in-depth code review but would appreciate your thoughts on the overall code structure and how this package aligns or overlaps with what you’ve been considering for similar tools, particularly in relation to Payu. We’d also appreciate your input regarding provenance tracking.

Our current plan is to carefully manage these tools, including this one, om3-utils, and make_diag_table to ensure they are well-structured and maintainable, and aligned with broader development goals.

Some notes:

  1. This tool will be moved out of its current repo but placed into a new repo to improve clarity and maintainability.
  2. The tool currently clones the om3-utils repo as part of its workflow since it relies on some parsers from that repo. We plan to remove this auto-cloning feature and instead manage dependencies through proper Python packaging.

@minghangli-uni
Copy link
Contributor Author

Closing this issue, as the functionality is now covered by two separate repos:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant