[10주차] API개발 미션(KoSeonJe) #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoSeonJe
commented
Sep 13, 2023
•
KoSeonJe
commented
wonjunYou
reviewed
Sep 18, 2023
| memberService.createUser(createMemberRequest); | ||
| } | ||
|
|
||
| @PutMapping(value = "/{memberId}") |
|
|
||
| private String name; | ||
|
|
||
| } |
| } | ||
|
|
||
| @GetMapping(value = "/{memberId}") | ||
| public MemberResponse getMemberInfo(@PathVariable Long memberId) { |
| memberRepository.save(member); | ||
| } | ||
|
|
||
| public MemberResponse getMemberInfo(Long memberId) { |
There was a problem hiding this comment.
dto에 대한 변환 책임을 controller에서 변환하는 게 옳은가? service에서 변환이 옳은가? 한번 차이를 비교해보면 좋겠다.
| memberRepository.save(member); | ||
| } | ||
|
|
||
| public MemberResponse getMemberInfo(Long memberId) { |
| public void updateUserInfo(Long memberId, UpdateMemberRequest updateMemberRequest) { | ||
| Member member = findOneUser(memberId); | ||
| member.update(updateMemberRequest.getAuthId(), updateMemberRequest.getName()); | ||
| memberRepository.save(member); |
Comment on lines
+45
to
+46
|
|
||
|
|
|
|
||
| private final PostRepository postRepository; | ||
|
|
||
| private final MemberService memberService; |
Comment on lines
+1
to
+18
| spring: | ||
| datasource: | ||
| url: jdbc:mysql://localhost:3306/cow?createDatabaseIfNotExist=true | ||
| driver-class-name: com.mysql.cj.jdbc.Driver | ||
| username: root | ||
| password: 1234 | ||
|
|
||
|
|
||
| jpa: | ||
| hibernate: | ||
| ddl-auto: create | ||
| properties: | ||
| hibernate: | ||
| show_sql: true | ||
| format_sql: true | ||
|
|
||
| server: | ||
| port: 9090 |
There was a problem hiding this comment.
이런 yml파일에 컬럼들을 암호화를 한다던가? 혹은 직접 github에 노출시키지 않는 방법?
1.jasypt
2. github secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.