Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determinism: Don't iterate over HashMaps #1919

Open
doug-q opened this issue Feb 12, 2025 · 0 comments
Open

Determinism: Don't iterate over HashMaps #1919

doug-q opened this issue Feb 12, 2025 · 0 comments

Comments

@doug-q
Copy link
Collaborator

doug-q commented Feb 12, 2025

In SimpleReplacement we iterate over HashMaps to connect nodes. One might think this is fine, but the order you connect nodes affects the order that links are reported in linked_outputs.

We should instead use a BTreeMap.

We should audit the codebase for all iterations over HashSets and HashMaps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doug-q