Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nondeterminism in lazify-measure #766

Merged
merged 9 commits into from
Feb 12, 2025
Merged

fix: nondeterminism in lazify-measure #766

merged 9 commits into from
Feb 12, 2025

Conversation

doug-q
Copy link
Contributor

@doug-q doug-q commented Feb 6, 2025

No description provided.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (0e78663) to head (510715f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   82.21%   82.24%   +0.02%     
==========================================
  Files          63       63              
  Lines        7767     7771       +4     
  Branches     7511     7515       +4     
==========================================
+ Hits         6386     6391       +5     
+ Misses        991      990       -1     
  Partials      390      390              
Flag Coverage Δ
rust 82.23% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doug-q doug-q marked this pull request as ready for review February 12, 2025 13:08
@doug-q doug-q requested a review from a team as a code owner February 12, 2025 13:08
@doug-q doug-q requested a review from aborgna-q February 12, 2025 13:08
@doug-q doug-q force-pushed the doug/sort-linked-inputs branch from f29031c to 1ebb2c0 Compare February 12, 2025 13:09
ABorgna

This comment was marked as duplicate.

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.
As discussed elsewhere, we should probably make SimpleReplacement deterministic and remove the sorts here.

@doug-q
Copy link
Contributor Author

doug-q commented Feb 12, 2025

Created CQCL/hugr#1919

@doug-q doug-q added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit d2ad66d Feb 12, 2025
17 checks passed
@doug-q doug-q deleted the doug/sort-linked-inputs branch February 12, 2025 13:41
@hugrbot hugrbot mentioned this pull request Feb 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 12, 2025
## 🤖 New release

* `tket2`: 0.7.1 -> 0.7.2 (✓ API compatible changes)
* `tket2-hseries`: 0.8.0 -> 0.9.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`

<blockquote>

##
[0.7.1](tket2-v0.7.0...tket2-v0.7.1)
- 2025-01-10

### Bug Fixes

- remove unicode pi symbols in rotation extension (#743)
</blockquote>

## `tket2-hseries`

<blockquote>

##
[0.9.0](tket2-hseries-v0.8.0...tket2-hseries-v0.9.0)
- 2025-02-12

### Bug Fixes

- Use `RemoveDeadFuncsPass` instead of deprecated `remove_polyfuncs()`
(#759)
- nondeterminism in lazify-measure (#766)

### New Features

- *(tket2-hseries)* Add `tket2.wasm` extension (#737)
- force-order qfree early and qalloc late. (#762)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
@hugrbot hugrbot mentioned this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants