Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nondeterminism in lazify-measure #766

Merged
merged 9 commits into from
Feb 12, 2025
Merged

fix: nondeterminism in lazify-measure #766

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d854cf7
fix: Fix nondeterminism in lazify-measure
doug-q Feb 4, 2025
c28a482
revert devnix changes
doug-q Feb 6, 2025
470f3de
comments
doug-q Feb 6, 2025
29ce1e3
fixup
doug-q Feb 6, 2025
d5f0d2c
add unnonlocalpass
doug-q Feb 6, 2025
f056ae4
pin to git not local path
doug-q Feb 6, 2025
1ebb2c0
Revert "add unnonlocalpass"
doug-q Feb 12, 2025
8505d4e
Update tket2-hseries/src/lazify_measure.rs
doug-q Feb 12, 2025
510715f
Update tket2-hseries/src/lazify_measure.rs
doug-q Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions tket2-hseries/src/lazify_measure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,14 @@ impl LazifyMeasureRewrite {
Self::check_signature(node, QSystemOp::LazyMeasure, hugr.get_optype(node))?;

let subgraph = SiblingSubgraph::from_node(node, &hugr);
let uses = hugr.linked_inputs(node, 0).collect_vec();
let uses = {
// SimpleReplacement adds edges in a nondeterministic order. This
// results in linked_inputs returning items in a nondeterministic
// order. We sort them here to restore determinism.
let mut v = hugr.linked_inputs(node, 0).collect_vec();
v.sort();
v
};
let (lazy_measure_node, replacement) = {
let bool_uses = uses.len();
let mut builder =
Expand Down Expand Up @@ -165,7 +172,12 @@ impl LazifyMeasureRewrite {
Self::check_signature(node, QSystemOp::LazyMeasureReset, hugr.get_optype(node))?;

let subgraph = SiblingSubgraph::from_node(node, &hugr);
let uses = hugr.linked_inputs(node, 1).collect_vec();
let uses = {
// See comment in try_new_measure
let mut v = hugr.linked_inputs(node, 1).collect_vec();
v.sort();
v
};
let (lazy_measure_reset_node, replacement) = {
let bool_uses = uses.len();
let mut builder = {
Expand Down
Loading