Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambdify for tensor.Daggered #210

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

kinianlo
Copy link
Contributor

@kinianlo kinianlo commented Feb 17, 2025

Solves issue #206 by defining a lambdify method to tensor.Daggered. The idea is to apply lambdify to the underlying box of the Daggered and then promoting the result to tensor.Daggered, which is inspired by how quantum.Controlled.lambdify is handled.

This example mentioned in #206 no longer produces the error.

@neiljdo neiljdo linked an issue Feb 19, 2025 that may be closed by this pull request
@neiljdo neiljdo changed the title Fix lambdify for tensor.Daggered Fix lambdify for tensor.Daggered Feb 21, 2025
@neiljdo neiljdo self-requested a review February 21, 2025 10:42
Copy link
Collaborator

@neiljdo neiljdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thank you for the PR 😄

@neiljdo neiljdo merged commit efb02f8 into CQCL:main Feb 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daggered breaks lambdify
2 participants