Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax type restrictions on QuantumModel #212

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Relax type restrictions on QuantumModel #212

merged 4 commits into from
Feb 20, 2025

Conversation

neiljdo
Copy link
Collaborator

@neiljdo neiljdo commented Feb 20, 2025

This makes QuantumModel less numpy-specific and suitable for use as a parent class to other quantum models using a different backend (see #208).

@neiljdo neiljdo requested a review from dimkart February 20, 2025 12:25
@neiljdo neiljdo requested a review from dimkart February 20, 2025 16:34
dimkart
dimkart approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@dimkart dimkart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Let's check if it resolves the typing issues in #208.

@neiljdo neiljdo merged commit 68ea9bb into CQCL:main Feb 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimkart dimkart dimkart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neiljdo @dimkart