-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Subgraph::copy_in_parent #182
Merged
Merged
Changes from 20 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7e132b7
Make is_multiport a method of LinkView
acl-cqc e88eeb3
Revert "Make is_multiport a method of LinkView"
acl-cqc ac60883
Add LinkView::endpoint_port
acl-cqc bfb2aed
Add SubGraph::copy_in_parent for any LinkMut, error+restore on non-mu…
acl-cqc 666b3ff
Avoid double-copy by duplicating code for graph insertion
acl-cqc 0113ca3
Remove unnecessary 'Clone' bounds
acl-cqc b5b7b58
refs.rs: implement {Port/Link/Multi}{View,Mut} for &mut G
acl-cqc 6550cd7
First test, fix one-direction-only
acl-cqc 1a5e392
Add test with edges over boundary; assert_same_for_nodes
acl-cqc 83b9607
Test on MultiPortGraph
acl-cqc 1b8faa4
Remove extraneous comment - Subgraph is not a LinkMut so impossible
acl-cqc 093430b
fmt
acl-cqc f211e11
In error test, check nodes same before/after
acl-cqc 46e2dbb
Revert "Add LinkView::endpoint_port"
acl-cqc e5d901c
Also remove endpoint_port for impl LinkMut for &mut G
acl-cqc bbaa70d
...and update to constrain by Into<PortIndex>
acl-cqc f227366
test_bad_boundary and test_multi: generalize to both directions
acl-cqc 725af27
Separate test_c,py_in_parent_multi into _input and _output
acl-cqc 090b661
Add comment about self-cycles
acl-cqc 6d8fc63
Add CopySubgraphError, unwrap most LinkError's
acl-cqc 99aca55
missing refs
acl-cqc b6cba8d
non-exhaustive error
acl-cqc 4317f1f
Drop redundant Into<PortIndex> bound
acl-cqc 21c1a09
docs, re-export CopySubgraphError
acl-cqc a2bd930
tidy imports
acl-cqc eeb5257
use expect
acl-cqc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add
MultiMut
too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, also MultiView for
&mut G