Feat/inject footer #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanCQ
reviewed
Oct 7, 2024
Comment on lines
+9
to
+10
| renderIn.style.padding = '0' | ||
| renderIn.style.margin = '0' |
aidanCQ
reviewed
Oct 7, 2024
| @@ -0,0 +1,18 @@ | |||
| @echo off | |||
There was a problem hiding this comment.
You should install git and use bash to run the shell script. Most devs work on linux or MacOS and I'd consider a batch file to be non-standard.
aidanCQ
reviewed
Oct 7, 2024
| call npm run build | ||
| echo "Copying UI assets to dist..." | ||
| copy /y /v .\build\injectNav.global.js ..\dist\_static\injectNav.global.js | ||
| copy /y /v .\build\injectFooter.global.js ..\dist\_static\injectFooter.global.js |
There was a problem hiding this comment.
This addition is missing in build-dist.sh. Keeping the build logic to one file should prevent this drift.
aidanCQ
reviewed
Oct 7, 2024
Comment on lines
-234
to
-247
| {% trans %}Made with {% endtrans -%} | ||
| {%- if show_sphinx -%} | ||
| {% trans %}<a href="https://www.sphinx-doc.org/">Sphinx</a> and {% endtrans -%} | ||
| <a class="muted-link" href="https://pradyunsg.me">@pradyunsg</a>'s | ||
| {% endif -%} | ||
| {% trans %} | ||
| <a href="https://github.com/pradyunsg/furo">Furo</a> | ||
| {% endtrans %} | ||
|
|
||
| {%- if last_updated -%} | ||
| <div class="last-updated"> | ||
| {% trans last_updated=last_updated|e -%} | ||
| Last updated on {{ last_updated }} | ||
| {%- endtrans -%} |
There was a problem hiding this comment.
I would leave all the default content as is, apart from things we are making custom. It makes it clearer what we have modified vs what was original. For example, the furo attribution should be left untouched imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injecting react footer in sphinx html template: