-
Notifications
You must be signed in to change notification settings - Fork 16
Add Dockerfile #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
making
wants to merge
2
commits into
CRaC:master
Choose a base branch
from
making:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
FROM azul/zulu-openjdk:21-jdk-crac-latest as builder | ||
WORKDIR application | ||
|
||
ADD ./.mvn .mvn/ | ||
ADD ./mvnw mvnw | ||
ADD ./pom.xml pom.xml | ||
ADD ./src src/ | ||
ADD ./.git .git/ | ||
RUN ./mvnw -V clean package -DskipTests --no-transfer-progress && \ | ||
cp target/*.jar application.jar && \ | ||
java -Djarmode=layertools -jar application.jar extract | ||
|
||
FROM azul/zulu-openjdk:21-jdk-crac-latest | ||
WORKDIR application | ||
|
||
COPY --from=builder application/dependencies/ ./ | ||
COPY --from=builder application/spring-boot-loader/ ./ | ||
COPY --from=builder application/snapshot-dependencies/ ./ | ||
COPY --from=builder application/application/ ./ | ||
COPY entrypoint.sh ./ | ||
|
||
ENTRYPOINT ["/application/entrypoint.sh"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#!/bin/bash | ||
mkdir -p $CHECKPOINT_RESTORE_FILES_DIR | ||
export JAVA_TOOL_OPTIONS="${JAVA_TOOL_OPTIONS} -XX:+ExitOnOutOfMemoryError" | ||
|
||
if [ -z "$(ls $CHECKPOINT_RESTORE_FILES_DIR/core-*.img 2>/dev/null)" ]; then | ||
echo "Save checkpoint to $CHECKPOINT_RESTORE_FILES_DIR" 1>&2 | ||
java -XX:CRaCCheckpointTo=$CHECKPOINT_RESTORE_FILES_DIR org.springframework.boot.loader.launch.JarLauncher & | ||
sleep ${SLEEP_BEFORE_CHECKPOINT:-10} | ||
jcmd org.springframework.boot.loader.launch.JarLauncher JDK.checkpoint | ||
sleep ${SLEEP_AFTER_CHECKPOINT:-3} | ||
else | ||
echo "Restore checkpoint from $CHECKPOINT_RESTORE_FILES_DIR" 1>&2 | ||
fi | ||
|
||
(echo 128 > /proc/sys/kernel/ns_last_pid) 2>/dev/null || while [ $(cat /proc/sys/kernel/ns_last_pid) -lt 128 ]; do :; done | ||
java -XX:CRaCRestoreFrom=$CHECKPOINT_RESTORE_FILES_DIR & | ||
JAVA_PID=$! | ||
|
||
stop_java_app() { | ||
kill -SIGTERM $JAVA_PID | ||
} | ||
|
||
trap stop_java_app SIGINT | ||
wait $JAVA_PID |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need NET_ADMIN and SYS_ADMIN in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I tried, NET_ADMIN is required on restore. Without this option you will get the following error:
Similarly, SYS_ADMIN is required at checkpoint. Without this option you will get the following error:
Strictly speaking, the options required at checkpoint and restore are different, but normally we would want to pass options that can be used in both cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I overlooked this PR.
The errors coming from the lack of NET_ADMIN are not critical, this is a bug they were reported as errors.
Regarding SYS_ADMIN, I believe it's possible to avoid it with changes in entrypoint.sh, for which I have a very dirty PoC. remove-extra-caps.diff.txt
But before going that route, how do you find #12, which also demonstrates creation of
docker container?