Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Comments

Fix <select> dropdown background color#73

Merged
ColdHeat merged 3 commits intoCTFd:mainfrom
erdnaxe:fix-select-css
Mar 19, 2024
Merged

Fix <select> dropdown background color#73
ColdHeat merged 3 commits intoCTFd:mainfrom
erdnaxe:fix-select-css

Conversation

@erdnaxe
Copy link
Contributor

@erdnaxe erdnaxe commented Mar 15, 2024

When using a dark-mode Bootstrap variant with a Chromium-based browser, <select> elements contain white text on white background.

This is due to main.scss overriding the background super property, discarding Bootstrap background-color property.

Also applying .form-control on select elements is non-standard and was contributing to this issue (https://getbootstrap.com/docs/5.0/forms/select/#default).

Before/after this patch:
before
after

@ColdHeat
Copy link
Member

I believe you need to rebuild the CSS files here. If you can do that I can merge pretty easily, if not I'm happy to build it for you as well.

@erdnaxe
Copy link
Contributor Author

erdnaxe commented Mar 15, 2024

Thanks! I was unsure about whether I should rebuild the CSS here as it could cause merge conflicts.

@ColdHeat ColdHeat merged commit f4b57b4 into CTFd:main Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants