Feature/add artifact build #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 17, 2025 11:32
…e consistent with other tests)
hodgestar
approved these changes
Oct 21, 2025
Member
hodgestar
left a comment
hodgestar
left a comment
There was a problem hiding this comment.
It would be nice to add some spot tests, but very happy just to merge this as is.
Possible spot tests:
- Wheel:
- Install
- Run tests somehow.
- sdist:
- Spot check important files (license, pyproject.toml, data files, ...)
Member
Author
|
I've added a step to install and run tests against the wheel (which did identify some issues, which are also fixed). I'll try do something on testing the sdist over the next few days |
Member
Author
|
I've now added a compare between the generated sdist and the source branch, as the easiest way to check that everything we want is there I have verified that the test correctly fails when files aren't present - see https://github.com/drnlm/wafer/actions/runs/18799782582/job/53645588751 |
hodgestar
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a set to build the sdist and wheel in the CI pipeline, so we can at least check that it continues working.
It would be useful to add some checks to the contents to avoid regressions, but I'm not sure of the best approach thee.