Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclue RHS factResult after condition evaluation #279

Open
antpingelli opened this issue Sep 16, 2021 · 2 comments
Open

Inclue RHS factResult after condition evaluation #279

antpingelli opened this issue Sep 16, 2021 · 2 comments
Milestone

Comments

@antpingelli
Copy link

We are using the functionality to allow the LHS attribute to be compared to a RHS attribute (demonstrated in this example) but noticed that in the rule result, only the LHS factResult is included. Would it be possible to also include the RHS factResult? I am not too familiar with the code but it seems like the logic is contained below

.then(evaluationResult => {
const passes = evaluationResult.result
condition.factResult = evaluationResult.leftHandSideValue
condition.result = passes
return passes
})

and a logic statement along the lines of
if (condition.value is an object) condition.value.factResult = evaluationResult.rightHandSideValue
could be added?

If there are no issues with this I am happy to open a PR

@MattCopenhaver
Copy link
Contributor

@antpingelli This would be helpful in my use case as well.

@naveen-shetty
Copy link

I would like this feature as well. @CacheControl any thoughts here ?

@chris-pardy chris-pardy added this to the version 7 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants