Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched-ext: introduce the concept of performance profiles #19

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

arighi
Copy link
Contributor

@arighi arighi commented Aug 24, 2024

Add an extra combo box to select the "performance profile" for the currently selected sched-ext scheduler. The selected profile will be automatically converted into the appropriate flags for the chosen scheduler.

Currently, only scx_bpfland and scx_lavd are supported, so the additional combo box will be visible only when one of these schedulers is selected.

@ventureoo ventureoo requested a review from vnepogodin August 24, 2024 13:36
@arighi arighi force-pushed the sched-ext-profiles branch from 2b60a5d to 20957ee Compare August 24, 2024 18:29
Copy link
Member

@ptr1337 ptr1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Tested-by: Peter Jung [email protected]

@vnepogodin
Copy link
Member

vnepogodin commented Aug 25, 2024

also run clang-format -i src/*.cpp to format according to style

besides that all good

Add an extra combo box to select the "performance profile" for the
currently selected sched-ext scheduler. The selected profile will be
automatically converted into the appropriate flags for the chosen
scheduler.

Currently, only scx_bpfland and scx_lavd are supported, so the
additional combo box will be visible only when one of these schedulers
is selected.

Tested-by: Peter Jung <[email protected]>
Signed-off-by: Andrea Righi <[email protected]>
@arighi arighi force-pushed the sched-ext-profiles branch from 20957ee to a2f77e9 Compare August 26, 2024 11:56
@arighi
Copy link
Contributor Author

arighi commented Aug 26, 2024

@vnepogodin PR updated with (I think) all your suggestions applied, thanks!

Copy link
Member

@vnepogodin vnepogodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@vnepogodin vnepogodin merged commit 9da530f into CachyOS:develop Aug 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants