Implement equation_of_line and setup CI testing
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomMelt
approved these changes
Jun 25, 2024
| push: | ||
| branches: ["main"] | ||
|
|
||
| # Triggers the workflow on pushes to pull requests |
There was a problem hiding this comment.
👍 thanks for the detailed comments. It's clear to see what each bit of the workflow yml does
| - name: Install Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.x' |
There was a problem hiding this comment.
what is the benefit of '3.x' vs '3.12' for example?
There was a problem hiding this comment.
It uses the latest available minor release of Python 3, rather than pinning to a particular version. (See https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#using-a-specific-python-version.)
|
Thanks for the review @TomMelt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1.
Closes #6.
This PR provides an implementation for the$y=mx+c$ formula.
equation_of_linefunction using the standardIt also sets up a test suite for continuous integration testing.