-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to work with ink! 5.0.0 #16
Conversation
In general I'm ready to approve the PR but I wonder whether you've considered the current situation with 5.0.0-rc release - the "rc" part means it's release candidate only, so there will come 5.0.0 release at some point. In theory, 5.0.0 release can be backwards incompatible with the *-rc release and here we're already releasing the new version. What do you think? |
Yes, I'm aware it's maybe a bit premature. But I tested these changes also on version use-ink/ink#2063 which most likely will end up as ink! 5.0.0. Also, this repo here has versioned releases to crates, I think nothing particularly bad will happen if the |
So just by bumping the version in |
Nope, publishing on crates.io is a manual process triggered locally via |
Personally I prefer when it's done automatically, when it detects a new version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool, I've been playing around with it and everything seems to work, nicely done!
No description provided.