Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release-11 to alephzero #144

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Merge release-11 to alephzero #144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
123d90a
Fix for suspensions started in era >= 1000 (#142)
Marcin-Radecki Feb 13, 2025
4cf4c89
Merge branch 'alephzero' into cp-123d90aa01
Marcin-Radecki Feb 17, 2025
ecf5711
linter
Marcin-Radecki Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions packages/page-staking/src/Suspensions/Suspensions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright 2017-2025 @polkadot/app-staking authors & contributors
// SPDX-License-Identifier: Apache-2.0

import type { u16, Vec } from '@polkadot/types';
import type { u8, u16, u32, Vec } from '@polkadot/types';
import type { EraIndex, EventRecord, Hash, SessionIndex } from '@polkadot/types/interfaces';
import type { Perbill } from '@polkadot/types/interfaces/runtime';
import type { Codec } from '@polkadot/types/types';
Expand All @@ -28,47 +28,56 @@ interface FinalityBanConfig {
banPeriod: EraIndex,
}

interface BanReason {
insufficientProduction?: u32,
insufficientFinalization?: u32,
otherReason?: Vec<u8>,
}
interface BanInfo {
reason: BanReason,
start: u32,
}

function parseEvents (events: EventRecord[], productionBanConfigPeriod: number, finalizationBanConfigPeriod: number): SuspensionEvent[] {
return events.filter(({ event }) => COMMITTEE_MANAGEMENT_NAMES.includes(event.section) && event.method === 'BanValidators')
.map(({ event }) => {
const raw = event.data[0] as unknown as Codec[][];

return raw.map((value) => {
const address = value[0].toString();
const reasonAndEra = value[1].toHuman() as unknown as Record<string, Codec>;

const reasonTypeAndValue = reasonAndEra.reason as unknown as Record<string, string>;
const reasonType = Object.keys(reasonTypeAndValue)[0];
const reasonValue = Object.values(reasonTypeAndValue)[0];
const era = Number(reasonAndEra.start.toString());
const banInfo = value[1].toJSON() as unknown as BanInfo;

const reason = banInfo.reason;
const era = Number(banInfo.start.toString());

if (reasonType === 'OtherReason') {
if (reason.otherReason !== undefined) {
return {
address,
era,
suspensionLiftsInEra: era + productionBanConfigPeriod,
suspensionReason: reasonValue
suspensionReason: reason.otherReason.toString()
};
} else if (reasonType === 'InsufficientProduction') {
} else if (reason.insufficientProduction !== undefined) {
return {
address,
era,
suspensionLiftsInEra: era + productionBanConfigPeriod,
suspensionReason: `Insufficient block production in at least ${reasonValue} sessions`
suspensionReason: `Insufficient block production in at least ${reason.insufficientProduction.toString()} sessions`
};
} else if (reasonType === 'InsufficientFinalization') {
} else if (reason.insufficientFinalization !== undefined) {
return {
address,
era,
suspensionLiftsInEra: era + finalizationBanConfigPeriod,
suspensionReason: `Insufficient finalization in at least ${reasonValue} sessions`
suspensionReason: `Insufficient finalization in at least ${reason.insufficientFinalization.toString()} sessions`
};
} else {
return {
address,
era,
suspensionLiftsInEra: era + productionBanConfigPeriod,
suspensionReason: `${reasonType} : ${reasonValue}`
suspensionReason: 'Unknown ban reason.'
};
}
});
Expand Down
Loading