Skip to content

Fix foundation.xml to load with proto 2.0 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix foundation.xml to load with proto 2.0 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foundation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<spawns>
<spawn team="blue-team" region="blue-spawn" yaw="-90" kit="default-kit"/>
<spawn team="red-team" region="red-spawn" yaw="90" kit="default-kit"/>
<default region="default-spawn" yaw="180"/>
<spawn defult="true" region="default-spawn" yaw="180"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to be default ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's supposed to be how the pr says, default spawn no longer exists, it's an attrubute now

Copy link

@connorjayr connorjayr Aug 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new attribute named defult?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's named default

Copy link
Member Author

@ElliottWhyman ElliottWhyman Aug 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops i can spell guys. @Pablete1234 elly knew what the pr did he was teasing me ;(

</spawns>
<regions>
<cylinder id="blue-spawn" base="-9.5,4,0.5" radius="0" height="0"/>
Expand Down