-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dot/sync): Implement warp sync strategy #4275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimartiro
commented
Oct 22, 2024
20937f7
to
6a553fb
Compare
dimartiro
commented
Oct 24, 2024
da62fed
to
7ad8347
Compare
dimartiro
commented
Nov 4, 2024
EclesioMeloJunior
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
c2789d6
to
93108f7
Compare
haikoschol
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nits/questions but LGTM!
014395d
to
42faaf7
Compare
timwu20
reviewed
Nov 14, 2024
timwu20
reviewed
Nov 14, 2024
42faaf7
to
89dcb62
Compare
967a77e
to
7294e7d
Compare
7294e7d
to
a3ee839
Compare
6004faf
to
a1b63c3
Compare
3eb6f56
to
c5d6815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-complex
Complex changes across multiple modules. Possibly will require additional research.
S-sync-kusama
related to particular network syncing.
S-sync-paseo
related to particular network syncing.
S-sync-polkadot
related to particular network syncing.
S-sync-westend
related to particular network syncing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implementation of the warp sync strategy.
This strategy is composed of 2 phases:
This goal of this strategy is to reach the latest finalized block of the canonical chain following authority set changes and validating justifications.
After this block is reached, we have to retrieve its state using the
state_sync
, that will allow us to build blocks on top of that one while we fill the gap between genesis and the latest finalized block retrieved by the warp sync.Summary of changes
warp_sync
strategyTests
make test
Issues
closes: #3183, #4277, #4268