Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typos, improve consistency, and update URLs #4451

Merged
merged 13 commits into from
Mar 10, 2025

Conversation

sergeypanin1994
Copy link
Contributor

fix: correct typos, improve consistency, and update URLs

  • Changed "initialises" to "initializes" (American English spelling).
  • Corrected "whats" to "what's".
  • Capitalized "Gossamer Testnet" for consistency.
  • Changed "finalisation" to "finalization" (American English spelling).
  • Corrected grammatical error: "extrinsics is used" to "extrinsics are used".
  • Changed "setup" to "set up" for proper verb usage.
  • Corrected "docker file" and "alice docker file" to "Dockerfile" for consistency.
  • Removed extra space before "Datadog API key".
  • Fixed spelling of "strategiey" to "strategy".
  • Updated Twitter URL to x.com format.

Replaced the outdated Twitter URL (https://twitter.com) with the updated x.com format (https://x.com) to align with the platform's rebranding.
- Changed "setup" to "set up" for proper verb usage.
- Corrected "docker file" and "alice docker file" to "Dockerfile" to maintain consistency.
- Removed extra space before "Datadog API key".
- Fixed "initialises" to "initializes" (American English spelling).
- Corrected spelling of "strategiey" to "strategy".
- Changed "initialises" to "initializes" (American English spelling).
- Corrected "whats" to "what's".
- Capitalized "Gossamer Testnet" for consistency.
- Changed "finalisation" to "finalization" (American English spelling).
- Fixed grammatical error by changing "extrinsics is used" to "extrinsics are used".
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.36%. Comparing base (d1ca7aa) to head (9c683ed).
Report is 292 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #4451      +/-   ##
===============================================
+ Coverage        50.51%   54.36%   +3.84%     
===============================================
  Files              230      345     +115     
  Lines            29006    45806   +16800     
===============================================
+ Hits             14653    24901   +10248     
- Misses           12856    18650    +5794     
- Partials          1497     2255     +758     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dimartiro
Copy link
Contributor

Hey @sergeypanin1994 , thanks for your contribution. Are you planning to address the latest comments from Eclesio? let me know in case we need to close this PR as stale

@sergeypanin1994
Copy link
Contributor Author

Привет@sergeypanin1994, спасибо за ваш вклад. Планируете ли вы ответить на последние комментарии от Eclesio? дайте мне знать, если нам нужно будет закрыть этот PR как устаревший

Fixed. Sorry for the wait.

@EclesioMeloJunior
Copy link
Member

@sergeypanin1994 there is 2 more comments, can you address them?

@sergeypanin1994
Copy link
Contributor Author

I corrected the mistake

@sergeypanin1994
Copy link
Contributor Author

Is everything okay?

@P1sar
Copy link
Member

P1sar commented Feb 28, 2025

Is everything okay?

Hey @sergeypanin1994 everything appears ok, will merge anytime soon.

Thank you for you contributions. If you are interested in future contributions please join our discord https://discord.gg/N7aaw676.
We provide incentives for external contributors for resolving available issues.

@haikoschol haikoschol dismissed EclesioMeloJunior’s stale review March 10, 2025 17:25

Comments have been addressed and we have two approvals from other reviewers.

@haikoschol haikoschol enabled auto-merge (squash) March 10, 2025 17:25
@haikoschol haikoschol merged commit bf3bc22 into ChainSafe:development Mar 10, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants