feat: (parachain) Bitfieldsigning subsystems #4530
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Freddy Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
freddyli7
changed the title
8 tasks
EclesioMeloJunior
approved these changes
Feb 11, 2025
Comment on lines
+57
to
+60
| err := b.ProcessBlockFinalizedSignal(msg) | ||
| if err != nil { | ||
| logger.Errorf("failed to process block finalized signal: %w", err) | ||
| } |
There was a problem hiding this comment.
given that the parachaintypes.BlockFinalizedSignal is not used we can just leave it as empty.
Suggested change
| err := b.ProcessBlockFinalizedSignal(msg) | |
| if err != nil { | |
| logger.Errorf("failed to process block finalized signal: %w", err) | |
| } |
axaysagathiya
approved these changes
Feb 12, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues