Fix serveral issues with the DCD module - #1094
Draft
robin-checkmk wants to merge 2 commits into
Draft
Conversation
|
This pull request has been stale for 60 days. It will close in 7 days. |
robin-checkmk
force-pushed
the
fix/serveral-issues-dcd
branch
from
July 15, 2026 05:57
f36f24d to
e398efc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Check the type of change your PR introduces:
What is the current behavior?
Four concrete issues:
debug line.
collection.
it should be removed.
Minor/secondary: json.JSONDecodeError (line 404) should be (ValueError, TypeError) for consistency; and the stale # Is this necessary? comment on line 576 should be resolved (the answer is
no — base_argument_spec() already handles this, and the required_if there just duplicates what Ansible enforces via api_auth_type).
The bug 1 is the only one with runtime impact.
What is the new behavior?
The above issues have been fixed.
Other information