Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citrix_state.py - added vmtoolsstate config #784

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Constey
Copy link

@Constey Constey commented Jan 29, 2025

Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.

General information

When monitoring citrix terminalserver with the citrix instance state it can often occour that the vmtoolstate is unknown, in special after reboots. this produces currently a lot of unknown errors - so we need to whitelist this as the "issue" has no affect and the systems are fully functional - it's just an citrix issue.

Configuration of the registrationstate was possible, but vmtoolstate not.
States are:
"vmtoolsstate": {
"NotPresent": 2,
"Unknown": 3,
"NotStarted": 1,
"Running": 0,
},

Bug reports

no cmk bug

Proposed changes

Just add the functionality to configure the vmtoolsstate via wato rules.

What is the expected behavior?
configuration of vmtoolsstate
What is the observed behavior?
the outcome of vmtoolsstate is not configurable

Copy link

github-actions bot commented Jan 29, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Constey
Copy link
Author

Constey commented Jan 29, 2025

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@Constey
Copy link
Author

Constey commented Jan 29, 2025

recheck

@mo-ki
Copy link
Member

mo-ki commented Feb 3, 2025

Hi @Constey
Thank you for your contribution. I think this is a nice improvement. Can I ask you to make the defaults the defaults, if you know what I mean? We try to choose the defaults of the rules to be the same as the values that would apply without any rules configured (if remotely reasonable).
Anyway: we are tracking this :-)

@mo-ki mo-ki added the tracked label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants