-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix scrollbar interaction in windowed mode on Windows using platform-specific styling #10907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* feat: add GitHub issue tracker workflow with Feishu notifications * fix: add missing environment variable for Claude translator in GitHub issue tracker workflow * fix: update environment variable for Claude translator in GitHub issue tracker workflow * Add quiet hours handling and scheduled processing for GitHub issue notifications - Implement quiet hours detection (00:00-08:30 Beijing Time) with delayed notifications - Add scheduled workflow to process pending issues daily at 08:30 Beijing Time - Create new script to batch process and summarize multiple pending issues with Claude * Replace custom Node.js script with Claude Code Action for issue processing - Migrate from custom JavaScript implementation to Claude Code Action for AI-powered issue summarization and processing - Simplify workflow by leveraging Claude's built-in GitHub API integration and tool usage capabilities - Maintain same functionality: fetch pending issues, generate Chinese summaries, send Feishu notifications, and clean up labels - Update Claude action reference from version pin to main branch for latest features * Remove GitHub issue comment functionality - Delete automated AI summary comments on issues after processing - Remove documentation for manual issue commenting workflow - Keep Feishu notification system intact while streamlining issue interactions
* feat: add GitHub issue tracker workflow with Feishu notifications * fix: add missing environment variable for Claude translator in GitHub issue tracker workflow * fix: update environment variable for Claude translator in GitHub issue tracker workflow * Add quiet hours handling and scheduled processing for GitHub issue notifications - Implement quiet hours detection (00:00-08:30 Beijing Time) with delayed notifications - Add scheduled workflow to process pending issues daily at 08:30 Beijing Time - Create new script to batch process and summarize multiple pending issues with Claude * Replace custom Node.js script with Claude Code Action for issue processing - Migrate from custom JavaScript implementation to Claude Code Action for AI-powered issue summarization and processing - Simplify workflow by leveraging Claude's built-in GitHub API integration and tool usage capabilities - Maintain same functionality: fetch pending issues, generate Chinese summaries, send Feishu notifications, and clean up labels - Update Claude action reference from version pin to main branch for latest features * Remove GitHub issue comment functionality - Delete automated AI summary comments on issues after processing - Remove documentation for manual issue commenting workflow - Keep Feishu notification system intact while streamlining issue interactions * Add OIDC token permissions and GitHub token to Claude workflow - Add `id-token: write` permission for OIDC authentication in both jobs - Pass `github_token` to Claude action for proper GitHub API access - Maintain existing issue write and contents read permissions
…ding spacing Co-authored-by: DeJeune <[email protected]>
Co-authored-by: DeJeune <[email protected]>
| --color-scrollbar-thumb-hover: var(--color-scrollbar-thumb-dark-hover); | ||
|
|
||
| --scrollbar-width: 6px; | ||
| --scrollbar-width: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot do not modify directly, maybe using media query is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to use body[os='windows'] selector instead of modifying the global value. The wider scrollbar and spacing now only apply on Windows platform. Commit: 787585f
Instead of modifying scrollbar width globally, use body[os='windows'] selector to apply wider scrollbar (10px) and spacing (2px transparent border) only on Windows platform. This addresses the window resize handle overlap issue specifically on Windows while maintaining the original scrollbar width (5-6px) on other platforms. Co-authored-by: DeJeune <[email protected]>
Problem
In non-maximized (windowed) mode on Windows, the right-side scrollbar was nearly impossible to operate with the mouse. When users attempted to drag the scrollbar, the window resize handle would intercept the interaction, causing the window to resize instead of scrolling the content.
This issue occurred because:
Solution
This PR implements a platform-specific CSS fix that addresses the issue only on Windows where it occurs, using the existing
body[os='windows']selector pattern.1. Windows-Specific Scrollbar Width
Changed the scrollbar track width from 5-6px to 10px only on Windows using platform-specific CSS selectors, providing a 66% larger target area that's much easier to interact with.
2. Windows-Specific Spacing from Window Edge
Added a 2px transparent border on the right side of the scrollbar thumb only on Windows using:
This creates a buffer zone between the scrollbar thumb and the window edge, preventing the resize handle from overlapping with the scrollbar's interactive area.
Technical Details
Platform-specific implementation:
Visual breakdown (Windows only):
Files Modified
src/renderer/src/assets/styles/scrollbar.css- Added Windows-specific scrollbar rules usingbody[os='windows']selectorsrc/renderer/src/assets/styles/responsive.css- Added Windows-specific width override usingbody[os='windows']selectorTesting
Tested scenarios:
Benefits
body[os='windows']selector already used elsewhere in the codebaseFixes #10843
Original prompt
Fixes #10843
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.