Skip to content

Update build.gradle #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gravenewsweekly
Copy link

Here’s what I fixed:

  1. Added applicationId – Ensures a unique app identifier.

  2. Increased minSdkVersion from 16 to 21 – Improves security and compatibility.

  3. Enabled vectorDrawables.useSupportLibrary – Allows vector drawables on older Android versions.

  4. Optimized ProGuard settings – Switched to proguard-android-optimize.txt for better performance and enabled shrinkResources to reduce APK size.

  5. Used JavaVersion.VERSION_1_8 – Instead of string literals, ensuring better code practices.

These changes make the project more optimized and future-proof.

Copy link
Member

@Naitbit Naitbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supporting old devices was intentional. Abandoning some of our users should have a good reason.

Opting in into vector drawable changes without actual vector drawable changes looks like something that would require QA pass for no improvement in user experience.

Prougard optimizations were skipped as we tried to keep dependencies and code size to a minimum to not need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants