Open
Conversation
Add special cases for primes 2, 3, 5 and 7. Proceed to Miller-Rabin and BPSW primality tests to get the correct primality result for other small primes that are factors in the prime products, which are used in the initial phase of primality testing. Previously small prime numbers up to 14951 were incorrectly reported as composite. As this primality test has never been used for so small numbers, there were no issues in its usage.
mariano54
reviewed
Jan 20, 2022
Contributor
mariano54
left a comment
mariano54
left a comment
There was a problem hiding this comment.
Thank you. Can we add a test for this?
Contributor
Author
|
Sure, I will add a test. |
The standard 'assert' is disabled due to NDEBUG and has no effect.
|
'This PR has been flagged as stale due to no activity for over 60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add special cases for primes 2, 3, 5 and 7. Proceed to Miller-Rabin and
BPSW primality tests to get the correct primality result for other small
primes that are factors in the prime products, which are used in the
initial phase of primality testing.
Previously small prime numbers up to 14951 were incorrectly reported as
composite. As this primality test has never been used for so small
numbers, there were no issues in its usage.