Update Mojang API endpoint and improve log file detection for Lunar#50
Open
CreationNation1 wants to merge 4 commits intoChit132:masterfrom
Open
Update Mojang API endpoint and improve log file detection for Lunar#50CreationNation1 wants to merge 4 commits intoChit132:masterfrom
CreationNation1 wants to merge 4 commits intoChit132:masterfrom
Conversation
Collaborator
|
at a glance LGTM, could be more efficient like calculating most recently updated ad-hoc but doesn't change much in performance wise any reason this is a draft still? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old Mojang API endpoint for converting usernames to UUIDs would occasionally have unexpected behavior. The endpoint string was updated to the newer endpoint that doesn't have the issues.
The Lunar log file path has changed numerous times over the development of the overlay; these changes aim to fix that by finding the most recently modified log file in the
.lunarclientdirectory.