Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print wLDO transfers more nicely in multisig utility #486

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Dec 17, 2021

So far the only transfers we have done, are wLDO transfers. We see a large number where it is difficult to count the zeros. We can improve this by special-casing wLDO.

Diff of target/debug/solido --config mainnet.json multisig show-transaction --transaction-address 3ccNd9MxfroqQ9gmaGQFTt1U65yRsUyiJi1oJhGwaz8E output:

diff --git before.txt after.txt
index 33d2e851..8d719712 100644
--- before.txt
+++ after.txt
@@ -23,9 +23,9 @@ Instruction:
     * GQ3QPrB1RHPRr4Reen772WrMZkHcFM4DL5q44x1BBTFm
       signer: true, writable: false
 
-  This is a Token instruction. It transfers tokens owned by the multisig.
+  This is an SPL token instruction. It transfers tokens.
     Token address: HZRCwxP2Vq9PCpPXooayhJ2bxTpo5xfpQrwB1svh332p
     From address:  T7VpKriUL68aQAKXFyfG3jJjvPHnxaC95XsjaZKSZ7b
     To address:    D89yDDs9dhd82SdM1teiHoH5miZMQ36Unc4r66rKFhVK
-    Amount:        4000000000000, of the token's smallest denomination
+    Amount:        40000.00000000 wLDO (Wormhole-wrapped Lido DAO token)

I also opened #485 to improve this further and add thousand separators and such, but for that it would be nice to have the impl_token! improvements that we have on the anchor-integration branch merged into main first. In the meantime, this is already an improvement.

@ruuda ruuda requested a review from enriquefynn December 17, 2021 12:40
Copy link
Member

@enriquefynn enriquefynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

So far the only transfers we have done, are wLDO transfers. We see a
large number where it is difficult to count the zeros. We can improve
this by special-casing wLDO.
@ruuda ruuda merged commit e7f493e into main Dec 23, 2021
@ruuda ruuda deleted the multisig-wldo branch December 23, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants