Arguments

[Carterpersall]

• Closes Feature Request: Arguments and Unattended Running #51
• Depends on All functions working with runspaces #67
• Using $env:args, the script scans for arguments; then if found, Invokes the codeblock associated with said arg.
  • \b is to prevent mutual words from causing issues (Ex: Install and InstallUpgrade would conflict without \b)

This will be expanded for the rest of the script as the script restructure for runspaces is finished.

[DeveloperDurp]

Looks like it should work though it might need to be lower in the script as the functions/scripts wouldn't be loaded into memory yet. Might even need to go until right before line 1316.

Hmm....

We might want to move everything that generates the GUI lower in the script as well. That way the functions/scripts load first and if we want CLI only it doesn't have to spend time loading things it doesn't need.

[DeveloperDurp]

Well that's interesting lol, ran it twice. But I had to put it at the bottom of the script.

(Code at top)

[Carterpersall]

The positioning issue should be fixed

[DeveloperDurp]

Quick test of the quit after I think we will need to add some logic so it can wait for the runspaces to finish. Or we might be able to do an invoke-command -scriptblock $InstallUpgrade since we don't have to worry about a gui

I will see what's going on with the double running of the install upgrade. Might need to rework the runspaces a little.

[Carterpersall]

Doing that seems to work
For me though it ran a few more than 2 times:

[DeveloperDurp]

Perfect! I will work on the runspaces with the CLI in mind

[Carterpersall]

Doing that seems to work For me though it ran a few more than 2 times:

I can't seem to recreate this issue so I dunno what's causing it to happen only occasionally

[DeveloperDurp]

Perhaps lingering runspaces from the last run, it works perfectly on my win10 instance.

[Carterpersall]

Perhaps lingering runspaces from the last run, it works perfectly on my win10 instance.

Oh yeah, that would make sense as that was my first time trying the different method.

[Carterpersall]

I might want to make another arg that if it's passed, none of the message boxes show. Currently, the message boxes pause the script making it not unattended. Another way to do it would be to have a check every time a message box is shown that checks if the argument is passed, then doesn't show the box when if it is passed.
Though this would mean that if QuitAfter isn't passed and the corresponding button is pressed, no message boxes would show. This could be prevented though by setting $env:args to an empty string before the form is opened and after the argument check.

But for now, I'm going to bed as all this programming has fried my brain.

[DeveloperDurp]

Yeah, that's something I am going to work on. I might have to separate the scripts a little and have a gui portion that controls the gui and formats the data into the same arguments you would use with say winget. That way you could pass $arg = "install:git.git" and it will install it the same way.

Also going to play around with the error handling to have it output errors to the terminal window and also allow you the option to do verbose in case you want to see what the script is doing.

[DeveloperDurp]

@Carterpersall FYI, the new script to call is $sync.ScriptsInstallPrograms, separated the GUI portion from the install script to make it easier to get the CLI functions to work without spamming message boxes.

[DeveloperDurp]

Once #50 gets merged you can add Installs to your arguments. Though we would need to add some logic so you could add in programs

Something like

$env:args = "UndoTweaks QuitAfter Install:git.git,winscp.winscp"

If($env:args -match '\bInstall\b'){
    Write-Verbose "Running"
    $Programstoinstall = (($env:args-split " " | Where-Object {$_ -like "install*"} ) -split ":")[1]
    Invoke-Command -scriptblock  $sync.ScriptsInstallPrograms -ArgumentList $Programstoinstall
}

We can also add this to get output in the console window
If($env:args -match '\bVerbose\b'){$VerbosePreference = "Continue"}

[Carterpersall]

Great Idea! When I find the time, I'll implement it.

[Carterpersall]

Added it in the most recent commit

[DeveloperDurp]

$sync.ScriptsInstallUpgrade will also be available in the same MR