Only install ecr-credential-helper when not already installed (#349)

* apt update less often in ecr_login.sh --------- Co-authored-by: Ryan Good <[email protected]>
CircleCI-Public · Aug 6, 2024 · 1d120cb · 1d120cb
1 parent 4d02c82
commit 1d120cb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.circleci/test-deploy.yml b/.circleci/test-deploy.yml
@@ -386,4 +386,4 @@ executors:
     machine:
       image: ubuntu-2204:current
       docker_layer_caching: true
-    resource_class: arm.medium
+    resource_class: arm.medium
diff --git a/src/scripts/ecr_login.sh b/src/scripts/ecr_login.sh
@@ -47,11 +47,17 @@ configure_config_json(){
 install_aws_ecr_credential_helper(){
     echo "Installing AWS ECR Credential Helper..."
     if [[ "$SYS_ENV_PLATFORM" = "linux" ]]; then
-        $SUDO apt update
-        $SUDO apt install amazon-ecr-credential-helper
+        HELPER_INSTALLED=$(dpkg --get-selections | (grep amazon-ecr-credential-helper || test $?) | awk '{print $2}')
+        if [[ "$HELPER_INSTALLED" != "install" ]]; then
+            $SUDO apt update
+            $SUDO apt install amazon-ecr-credential-helper
+        fi
         configure_config_json
     elif [[ "$SYS_ENV_PLATFORM" = "macos" ]]; then
-        brew install docker-credential-helper-ecr
+        HELPER_INSTALLED=$(brew list -q | grep -q docker-credential-helper-ecr || test $?)
+        if [[ "$HELPER_INSTALLED" -ne 0 ]]; then
+            brew install docker-credential-helper-ecr
+        fi
         configure_config_json
     else
         docker logout "${AWS_ECR_VAL_ACCOUNT_URL}"