Skip to content

draft PR: search functionality in custom shortcuts panel #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

palashb01
Copy link
Contributor

Fixes #48

Changes:

  • a search bar in the custom shortcut panel.

Demo Video:
circuitverse_draft_pr

Problem:

  • Currently to check whether the given custom input is assigned to something is a procedure where, inside customShortcuts.vue a function
    warnOverride($('#pressedKeys').text(), targetPref.value) is called where targetPref send something like this:

Screenshot from 2023-01-07 08-01-28

  • after this inside actions.js file a function is called ref, which iterate through all the present children of div and match whether it has been assigned already or not.

  • with the new changes if you search something then the number of shortcuts will reduce on the screen which reduces the child div;s because of this:

  • if you try to assign a shortcut that has already been assigned to something else( which is not shown on the screen) then it won't warn and just assign that shortcut to the given command.

I was wondering if there could be a way to implement this feature of checking the assigned shortcuts differently instead of children div's then this search functionality could work much better.

cc: @devartstar @tachyons

@netlify
Copy link

netlify bot commented Jan 7, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit d9d139f
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/63b8deb735234d0009016a0b
😎 Deploy Preview https://deploy-preview-53--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@commit-lint
Copy link

commit-lint bot commented Jan 7, 2023

Contributors

palashb01

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a search functionality to Custom keyboard shortcuts section
1 participant