-
Notifications
You must be signed in to change notification settings - Fork 40
Update to .Net 5 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .Net 5 #99
Conversation
@ChrisJollyAU Awesome! I'll review it over the weekend, so we can merge it next week. |
@lauxjpn Will there be a merge? |
@Edivad99 Thanks for pinging me! I was about half way done checking the PR. I will do the second half this week and then merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a couple of minor changes, added some code paths back that were removed but are needed etc.
I will upgrade the tests next.
Hello @lauxjpn, do you have a release date for the .Net 5 compatibility ? |
Hi, any news about the .NET5 update? |
Not yet, but we could merge it as "work-in-progress", so you could start using/testing it. |
I pushed PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#1533 to Pomelo yesterday, that we should heavily use in our test suite here to automatically skip tests that are not supported due to missing features in Jet/ACE. This might help us with not needing to manually annotate thousands of tests for skipping that are never going to succeed against Jet/ACE. |
Hello there! How can I obtaion some test build with EF Core 5 (or even EF Core 6) support? Thank you. |
I have scheduled time on Sunday to fix the tests and merge this. |
6870e8a
to
00a3548
Compare
Fix date/time related millisecond (double) support.
00a3548
to
ed42425
Compare
@ChrisJollyAU Thank you for your contribution! |
@lauxjpn No worries. |
@lauxjpn I've created an issue to track EF Core 6 progress. |
We will first release support for EF Core 5, before we make any official advances towards EF Core 6. |
The main code compiles and runs. I've used some simple select and update statements and it seems to be fine.
The test projects still need a lot of work
Addresses #98