Skip to content

Update to .Net 5 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 13, 2021
Merged

Update to .Net 5 #99

merged 11 commits into from
Dec 13, 2021

Conversation

ChrisJollyAU
Copy link
Member

@ChrisJollyAU ChrisJollyAU commented May 22, 2021

The main code compiles and runs. I've used some simple select and update statements and it seems to be fine.

The test projects still need a lot of work

Addresses #98

@lauxjpn lauxjpn added this to the 5.0.0 milestone May 22, 2021
@lauxjpn lauxjpn self-requested a review May 22, 2021 09:03
@lauxjpn
Copy link
Member

lauxjpn commented May 22, 2021

@ChrisJollyAU Awesome! I'll review it over the weekend, so we can merge it next week.
(Just ping me if I should forget to merge it for some reason.)

@Edivad99
Copy link

Edivad99 commented Jun 28, 2021

@lauxjpn Will there be a merge?

@lauxjpn
Copy link
Member

lauxjpn commented Jun 28, 2021

@Edivad99 Thanks for pinging me! I was about half way done checking the PR. I will do the second half this week and then merge it.

Copy link
Member

@lauxjpn lauxjpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a couple of minor changes, added some code paths back that were removed but are needed etc.

I will upgrade the tests next.

@renkazan
Copy link

Hello @lauxjpn, do you have a release date for the .Net 5 compatibility ?

@ceccacecca
Copy link

Hi, any news about the .NET5 update?

@lauxjpn
Copy link
Member

lauxjpn commented Sep 22, 2021

Not yet, but we could merge it as "work-in-progress", so you could start using/testing it.

@lauxjpn
Copy link
Member

lauxjpn commented Oct 7, 2021

I pushed PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#1533 to Pomelo yesterday, that we should heavily use in our test suite here to automatically skip tests that are not supported due to missing features in Jet/ACE.

This might help us with not needing to manually annotate thousands of tests for skipping that are never going to succeed against Jet/ACE.

@bairog
Copy link

bairog commented Dec 10, 2021

Not yet, but we could merge it as "work-in-progress", so you could start using/testing it.

Hello there! How can I obtaion some test build with EF Core 5 (or even EF Core 6) support? Thank you.

@lauxjpn
Copy link
Member

lauxjpn commented Dec 10, 2021

I have scheduled time on Sunday to fix the tests and merge this.

@lauxjpn lauxjpn force-pushed the net5structure branch 2 times, most recently from 6870e8a to 00a3548 Compare December 12, 2021 22:53
@lauxjpn lauxjpn merged commit b1fa143 into CirrusRedOrg:master Dec 13, 2021
@lauxjpn
Copy link
Member

lauxjpn commented Dec 13, 2021

@ChrisJollyAU Thank you for your contribution!

@ChrisJollyAU
Copy link
Member Author

@lauxjpn No worries.
Have started lood at ef6 but it is giving interesting stack traces

@ChrisJollyAU ChrisJollyAU deleted the net5structure branch December 13, 2021 12:15
@bairog
Copy link

bairog commented Dec 13, 2021

Have started lood at ef6 but it is giving interesting stack traces

@lauxjpn I've created an issue to track EF Core 6 progress.
I suppose that "interesting stack traces" that @ChrisJollyAU is talking about is the result of my testing of his test builds from here.
Anyway - good luck to you guys, looking forrward for getting EF Core 5 and 6 support soon.

@lauxjpn
Copy link
Member

lauxjpn commented Dec 13, 2021

We will first release support for EF Core 5, before we make any official advances towards EF Core 6.

@lauxjpn lauxjpn modified the milestones: 5.0.0, 5.0.0-alpha.1 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants