ACI L4-L7 Services (DCNE-155) #186
Conversation
| else: | ||
| path_type = 'paths' | ||
|
|
||
| path_dn = ('topology/pod-{0}/{1}-{2}/pathep-[{3}]'.format(pod_id, |
There was a problem hiding this comment.
should we include some form of validation of input to ensure valid path_dn is created?
There was a problem hiding this comment.
I'm not sure how much validation we can add, since the pathep for PCs and vPCs is just an IPG name (so just a generic string). The pod ID is already typed as int, and I've added a regex check to make sure the node ID is either an integer or a hyphen separated pair of integers.
anvitha-jain
force-pushed
the
feat/aci_l4l7
branch
from
9be4a81 to
2c8ec69
Compare
| threshold=dict(type="int"), | ||
| traffic_class=dict(type="int"), | ||
| http_version=dict(type="str", choices=["1.0", "1.1"]), | ||
| http_uri=dict(type="str"), |
There was a problem hiding this comment.
Module :
- Missing destination_port and detect_multiplier arguments (available when sla_type = TCP).
- missing description
Tests
-> in test cases
-> missing test cases with traffic_class, type_of_service arguments
-> missing test case when sla_type = L2ping
There was a problem hiding this comment.
destination_port and detect_multiplier already exist in the form of sla_port and multiplier, so added alias for them along with the description argument. Added assertions for traffic_class, type_of_service arguments but didn't add test for the choice l2ping because we don't usually test all the choices unless it has some extra functionality associated with it in our code.
| health_group=dict(type="str"), | ||
| ) |
There was a problem hiding this comment.
missing description argument in module
| device = module.params.get("device") | ||
|
|
There was a problem hiding this comment.
- Missing context_name argument.
- While testing device (aci_l4l7_device) is created and available on UI, but it is not attached to aci_l4l7_device_selection_policy. (required parameter)
There was a problem hiding this comment.
Added context and the test is complete
| argument_spec.update(aci_annotation_spec()) | ||
| argument_spec.update( | ||
| tenant=dict(type="str", aliases=["tenant_name"]), | ||
| contract=dict(type="str", aliases=["contract_name"]), |
There was a problem hiding this comment.
I don't think contract is the right name.
| logical_device=dict(type="str"), | ||
| logical_interface=dict(type="str"), | ||
| redirect_policy=dict(type="str"), | ||
| ) |
There was a problem hiding this comment.
-> contract might not be the right name.
-
In module custom_qos_policy, permit_logging and l3out arguments are missing
-
l3_dest and permit_log arguments missing in test cases
-
In Test :
- Modify L4-L7 Device Selection Logical Interface Context - fails
- Verify context query - fails
- Azure cloud fails at - Add a Bridge Domain in ansible_tenant
There was a problem hiding this comment.
permit_log already exists.
custom_qos_policy is a child
I don't see l3out?
test is passing
| module_object=context, | ||
| target_filter={"connNameOrLbl": context}, | ||
| ), | ||
| child_classes=["vnsRsLIfCtxToBD", "vnsRsLIfCtxToLIf", "vnsRsLIfCtxToSvcRedirectPol"], |
There was a problem hiding this comment.
child_classes=["vnsRsLIfCtxToBD", "vnsRsLIfCtxToLIf", "vnsRsLIfCtxToSvcRedirectPol"] -> should be modified by adding one more classes -> vnsRsLIfCtxToCustQosPol
There was a problem hiding this comment.
This could be an enhancement.
| tenant=dict(type="str", aliases=["tenant_name"]), | ||
| service_graph=dict(type="str"), | ||
| state=dict(type="str", default="present", choices=["absent", "present", "query"]), | ||
| ui_template_type=dict(type="str"), | ||
| ) |
There was a problem hiding this comment.
test case for ui_template_type missing
| tenant=dict(type="str", aliases=["tenant_name"]), | ||
| service_graph=dict(type="str"), | ||
| state=dict(type="str", default="present", choices=["absent", "present", "query"]), | ||
| connection_name=dict(type="str"), | ||
| direct_connect=dict(type="bool"), | ||
| unicast_route=dict(type="bool"), | ||
| adjacency_type=dict(type="str", choices=["l2", "l3"]), | ||
| ) |
There was a problem hiding this comment.
Missing connType and connDir from modules.
| DOCUMENTATION = r""" | ||
| --- | ||
| module: aci_l4l7_service_graph_template_abs_connection_conns | ||
| short_description: Manage L4-L7 Service Graph Template Connections (vns:RsAbsConnectionConns) |
There was a problem hiding this comment.
Do we need a separate module for relationship object?
There was a problem hiding this comment.
Here, it turns out that we can use this Rs object multiple times hence it makes sense to have a dedicated module
| tenant=dict(type="str", aliases=["tenant_name"]), | ||
| service_graph=dict(type="str"), | ||
| node=dict(type="str"), | ||
| state=dict(type="str", default="present", choices=["absent", "present", "query"]), | ||
| func_template_type=dict(type="str", choices=["fw_trans", "fw_routed", "adc_one_arm", "adc_two_arm", "other"]), | ||
| func_type=dict(type="str", choices=["go_to", "go_through", "l1", "l2"]), | ||
| device=dict(type="str"), | ||
| device_tenant=dict(type="str"), | ||
| managed=dict(type="bool"), | ||
| routing_mode=dict(type="str"), |
There was a problem hiding this comment.
missing isCopy argument in the module.
| tenant=dict(type="str", aliases=["tenant_name"]), | ||
| service_graph=dict(type="str"), | ||
| state=dict(type="str", default="present", choices=["absent", "present", "query"]), | ||
| node_name=dict(type="str", choices=["T1", "T2"]), |
There was a problem hiding this comment.
Looks like this module is built for 2 nodes, no example of what happens if there are more than 2 node, or when copy node is present.
There was a problem hiding this comment.
This module creates a terminal node. Can you please explain further by what you mean?
| svc_type=dict(type="str", choices=["adc", "fw", "others"]), | ||
| trunking=dict(type="bool"), | ||
| domain=dict(type="str"), | ||
| ) |
There was a problem hiding this comment.
fails on 6.2 v and azure cloud
There was a problem hiding this comment.
Not applicable on azure cloud and it's passing on the rest
| prom_mode=dict(type="bool"), | ||
| svc_type=dict(type="str", choices=["adc", "fw", "others"]), | ||
| trunking=dict(type="bool"), | ||
| domain=dict(type="str"), |
There was a problem hiding this comment.
rename arguments, no example for copy device
There was a problem hiding this comment.
@anvitha-jain
Added aliases for a few arguments.
Can you please elaborate "no example for copy device"?
| device=dict(type="str"), | ||
| logical_interface=dict(type="str"), | ||
| state=dict(type="str", default="present", choices=["absent", "present", "query"]), | ||
| encap=dict(type="str"), |
There was a problem hiding this comment.
missing configIssues (configuration issues) parameter.
| device=dict(type="str"), | ||
| logical_interface=dict(type="str"), | ||
| state=dict(type="str", default="present", choices=["absent", "present", "query"]), | ||
| concrete_device=dict(type="str"), | ||
| concrete_interface=dict(type="str"), |
There was a problem hiding this comment.
this is a relationship object.
There was a problem hiding this comment.
Here, it turns out that we can use this Rs object multiple times hence it makes sense to have a dedicated module
This PR includes modules and integration tests for L4-L7 services. The modules allow configuration of the following ACI classes: